Skip to content

add build in Docker #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add build in Docker #332

wants to merge 7 commits into from

Conversation

@karu2003
Copy link

@karu2003 karu2003 commented Oct 30, 2023

simple project build in Docker. no garbage in the system.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@karu2003
Copy link
Author

karu2003 commented Oct 30, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 30, 2023
@github-actions
@karu2003 has signed the CLA from Pull Request #332
3519c25
@karu2003 karu2003 force-pushed the docker branch 3 times, most recently from 26f0ec5 to 7eb52ac Compare November 6, 2023 18:42
@karu2003 karu2003 force-pushed the docker branch 2 times, most recently from 533f43a to a39a198 Compare January 2, 2025 07:18
@albfan
Copy link

albfan commented Feb 1, 2025

Whatever the process to get into this changes you should rework into atomic meaningful changes.

Some of the probably might be cherry-picked (like config the jobs in make, but not really related with this PR

albfan
albfan reviewed Apr 27, 2025
View reviewed changes
Copy link

@albfan albfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a general config for this.

If you want to do that as a build on docker, why someone will not want to build firmware?

force config on a docker build is wrong

albfan
albfan reviewed Apr 27, 2025
View reviewed changes
Copy link

@albfan albfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash into atomic change

albfan
albfan reviewed Apr 27, 2025
View reviewed changes
Copy link

@albfan albfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use meaningful commit messages.

If you want to use the cpus available say so on commit

albfan
albfan reviewed Apr 27, 2025
View reviewed changes
Copy link

@albfan albfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash

albfan
albfan reviewed Apr 27, 2025
View reviewed changes
Copy link

@albfan albfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash into an atomic change

@karu2003
Copy link
Author

karu2003 commented Apr 27, 2025

Whatever the process to get into this changes you should rework into atomic meaningful changes.

Some of the probably might be cherry-picked (like config the jobs in make, but not really related with this PR

you can close PR. it's been a long time. i use docker for myself.

@karu2003
Copy link
Author

karu2003 commented Apr 27, 2025

you can close PR. it's been a long time. i use docker for myself.

@albfan
Copy link

albfan commented Apr 28, 2025

You should close yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@albfan albfan albfan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karu2003 @albfan